freebsd-src icon indicating copy to clipboard operation
freebsd-src copied to clipboard

Address self reference links: open.2 mdmfs.8 cfumass.4 bhnd_erom.9 device_add_child.9

Open chrisdavidson opened this issue 1 year ago • 2 comments

open.2 - Changed openat .Xr reference to .Nm mdmfs.8 - Updates to .Xr references cfumass.4 - Updates to .Xr references bhnd_erom.9 - Updates to .Xr references device_add_child.9 - Updates to .Xr references

chrisdavidson avatar Mar 07 '24 16:03 chrisdavidson

I'm not sure if editing the title just makes a bunch of noise and is actually unhelpful, but if it's good, you could probably improve it by clarifying the pr title to mention the subsystem e.g. "manpages: fix 5 self-references".

Edit: to reviewers: is it correct and acceptable for me, as someone who is not any type of authority in this project, but is interested and has contributed/familiarized themselves with this subsystem, to leave approval after I read it and think it's very nice?

concussious avatar Mar 07 '24 16:03 concussious

thank you @concussious for the review and the tidbits.

The amount of detail to put in a git commit has been a learning, i went with being more extensive as this is pretty new. Your suggestion on maybe less is more is a good thing and will try that with the next one (if that makes sense to do).

chrisdavidson avatar Mar 07 '24 18:03 chrisdavidson

denoting this commit message is aligned to the conventions for the project.

chrisdavidson avatar Mar 21 '24 20:03 chrisdavidson

hi @mhorne if it would not be too much trouble, could you take a look at this pull request?

I went through and aligned things, got it down to 1 commit and did the commit log magic on it.

Thank you in advance.

chrisdavidson avatar Mar 22 '24 02:03 chrisdavidson

thank you, i will make note of that future updates.

chrisdavidson avatar Apr 03 '24 18:04 chrisdavidson