progress-stream icon indicating copy to clipboard operation
progress-stream copied to clipboard

Fix incorrect check which always yields true

Open rexxars opened this issue 8 years ago • 2 comments

I might be overlooking something trivial here, but I can't see any way where length is not a number? It's initialized as 0, so when you pipe an HTTP stream to it, it'll still be 0, and it'll just fall back and not try to read the length from the headers. Surely this isn't how it was supposed to be? :-)

rexxars avatar Dec 08 '16 12:12 rexxars

Hate to "bump", but any thoughts on this?

rexxars avatar Nov 26 '17 15:11 rexxars

Don't mean to rush you but any chance of getting this addressed soon? ;)

For those of you looking for a workaround, you can initialize the progress-stream instance with the option{ length: 'any non-numeric value' }. If your readable stream has a length to be read then this should work fine. If it doesn't have a readable length then I'm assuming this will break things.

jmenashe avatar Dec 25 '20 07:12 jmenashe