mail-for-good icon indicating copy to clipboard operation
mail-for-good copied to clipboard

Provide nice UI to choose date time for filtering campaigns with campaign created date time

Open karuppiah7890 opened this issue 7 years ago • 6 comments

For now I had to manually type the whole date time. It's quite tedious

karuppiah7890 avatar Jun 10 '17 13:06 karuppiah7890

The below screen shot shows how Plivo uses a nice UI to choose a from date and to date for filtering call logs :

plivo from

karuppiah7890 avatar Jun 11 '17 10:06 karuppiah7890

We've leveraged react-bootstrap-table to implement a large amount of data handling in this app. It's possible that they've implemented a feature akin to this. If not, the best approach from my perspective would be to submit a PR to this library and implement it directly. Will review this in due course.

AndrewWalsh avatar Jun 13 '17 21:06 AndrewWalsh

Yes, I did see that! I agree. But then, we are actually using version 3.0.0 beta (https://github.com/freeCodeCamp/Mail-for-Good/blob/master/package.json#L73), and the current version of react-boostrap-table is 3.4 from what I see in their package.json in master branch, but then, they have 4.0.0 beta too now

karuppiah7890 avatar Jun 14 '17 04:06 karuppiah7890

We can choose one of them, but choosing 4.0 will have breaking changes for us

karuppiah7890 avatar Jun 14 '17 04:06 karuppiah7890

Just out curiosity, does 4.0 have any functionality in this regard that's worth upgrading for?

AndrewWalsh avatar Jun 14 '17 21:06 AndrewWalsh

I haven't checked anything yet. I was planning on using another library, a bower component, but yes, I will check if React Bootstrap itself has any options for this UI

karuppiah7890 avatar Jun 15 '17 02:06 karuppiah7890