issues with tests for Design a Business Card lab

[majestic-owl448]

after #59930 campers are allowed to use the a elements for email and phone number.

But now there is an other set of situations that fail:

people often add more containers than asked, main, section etc

I wonder if we should change the requested div.business-card to a semating element, like main or section

And also I wonder in what way could the tests be changed to allow this creativity freedom.

[Sky-walkerX]

we can make an array of allowed elements like:

const elements = ['DIV','MAIN','SECTION','ARTICLE']; const card = document.querySelector('.business-card'); assert.include(allowed, card.tagName) to check if the element is one of the allowed ones

[majestic-owl448]

that would not fix the issue, as campers add extra containers inside .business-card

[Sky-walkerX]

Ohh, then we can remove that strict check for anchor tag to be direct child of element having class named business-card

[majestic-owl448]

We still need a way to individuate which anchor element to test. People like to add anchor elements with mailto and href for the p elements, which is what brough the change in that PR

[a2937]

Can we add ids to these elements?

[majestic-owl448]

if we add that to the user stories, it's a way for sure

[hbar1st]

someone on the forum ran into a problem with the test and I'm just linking it here for reference: https://forum.freecodecamp.org/t/design-a-business-card-design-a-business-card/752684

[majestic-owl448]

it is the same issue described here, it happens pretty often on the forum

[Sky-walkerX]

it is the same issue described here, it happens pretty often on the forum

Hey, does the PR I linked cover the requirements?

[majestic-owl448]

@Sky-walkerX it will need to be reviewed to know that

[Shivfun99]

i love to contribute in open source

[a2937]

i love to contribute in open source

We typically do not assign issues. Instead, we accept the first pull request that comprehensively solves the issue.

Issues labeled with help wanted or first timers only are open for contributions.

Please make sure you read our guidelines for contributing. We prioritize contributors following the instructions in our guide. Join us in our chat room or the forum if you need help contributing - our community will be happy to assist you.