freeCodeCamp icon indicating copy to clipboard operation
freeCodeCamp copied to clipboard

feat(curriculum): add css-typography quiz

Open Dhairya-A-Mehra opened this issue 1 year ago • 9 comments

Checklist:

Checklist:

Closes #56188

I have added questions for the CSS Typography Quiz. I have not tested this application on my local machine because I am developing this on Windows. However, I consulted with @naomi-lgbt , and they informed me that I am allowed to submit the PR without local testing. If any changes to the questions are needed, I am happy to make adjustments as required.

Dhairya-A-Mehra avatar Oct 03 '24 06:10 Dhairya-A-Mehra

request: do not keep closing and opening PRs, it creates a lot of unnecessary noise

majestic-owl448 avatar Oct 03 '24 07:10 majestic-owl448

request: do not keep closing and opening PRs, it creates a lot of unnecessary noise

do you want me to close this PR?

Dhairya-A-Mehra avatar Oct 03 '24 08:10 Dhairya-A-Mehra

no, I just asked you to stop closing and reopening, keep this one and don't close and reopen again please

majestic-owl448 avatar Oct 03 '24 08:10 majestic-owl448

no, I just asked you to stop closing and reopening, keep this one and don't close and reopen again please okay sure last one I closed because it was not in proper format given by you

Dhairya-A-Mehra avatar Oct 03 '24 08:10 Dhairya-A-Mehra

you can edit the title instead of closing and reopening a PR

majestic-owl448 avatar Oct 03 '24 08:10 majestic-owl448

You also do not need to make a new PR if you are asked to change something in the code, there you will need to push a new commit

majestic-owl448 avatar Oct 03 '24 08:10 majestic-owl448

Before I can review this in-depth, all code needs to be between backticks so our parser renders it in code tags. I've left a couple of examples.

Okay I'll do it

Dhairya-A-Mehra avatar Oct 06 '24 07:10 Dhairya-A-Mehra

note, you can make a single commit if you go to the Edited files tab, which is preferred

majestic-owl448 avatar Oct 09 '24 09:10 majestic-owl448

note, you can make a single commit if you go to the Edited files tab, which is preferred

I tried to commit this thing as a batch, but I was not able to do that, so made single commits. Sorry for that

Dhairya-A-Mehra avatar Oct 09 '24 10:10 Dhairya-A-Mehra

@a2937 I'll do the required changes

Dhairya-A-Mehra avatar Oct 16 '24 20:10 Dhairya-A-Mehra

Hey @Dhairya-A-Mehra,

Any progress on addressing requested changes?

gikf avatar Oct 22 '24 17:10 gikf

Hey @Dhairya-A-Mehra,

Any progress on addressing requested changes?

I will be committing the required changes in a few hours.

Dhairya-A-Mehra avatar Oct 22 '24 17:10 Dhairya-A-Mehra

You still have yet to respond to Ilenia's suggestion.

Oh, I am extremely sorry.

Dhairya-A-Mehra avatar Oct 24 '24 06:10 Dhairya-A-Mehra

Hi @Dhairya-A-Mehra. Congrats on your first pull request (PR)! 🎉

Thank you for your contribution to the page! 👍 We are happy to accept these changes and look forward to future contributions. 📝

gikf avatar Oct 28 '24 06:10 gikf

Hi @Dhairya-A-Mehra. Congrats on your first pull request (PR)! 🎉

Thank you for your contribution to the page! 👍 We are happy to accept these changes and look forward to future contributions. 📝

Thank You all for supporting me through this journey of contributing in your organization.

Dhairya-A-Mehra avatar Oct 29 '24 04:10 Dhairya-A-Mehra