freeCodeCamp icon indicating copy to clipboard operation
freeCodeCamp copied to clipboard

feat: yield new application programming interface

Open raisedadead opened this issue 3 years ago • 4 comments

Umbrella API PR. Do not merge or push commits here directly.

raisedadead avatar Nov 08 '22 17:11 raisedadead

:eyes: Review this PR in a CodeSee Review Map

View the CodeSee Map of this change

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

ghost avatar Nov 08 '22 17:11 ghost

gitpod-io[bot] avatar Nov 10 '22 07:11 gitpod-io[bot]

We are officially on Node.js 18 now. We have changed the merge requirements accordingly.

You will need to rebase this PR against the main branch OR Click the "Update branch" button to get the new checks going.

Thanks for your contribution.

raisedadead avatar Dec 19 '22 15:12 raisedadead

Socket Security Pull Request Report

👍 No new dependency issues detected in pull request

Pull request report summary
Issue Status
Install scripts ✅ 0 issues
Native code ✅ 0 issues
Bin script shell injection ✅ 0 issues
Unresolved require ✅ 0 issues
Invalid package.json ✅ 0 issues
HTTP dependency ✅ 0 issues
Git dependency ✅ 0 issues
Potential typo squat ✅ 0 issues
Known Malware ✅ 0 issues
Telemetry ✅ 0 issues
Protestware/Troll package ✅ 0 issues
Bot Commands

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore [email protected] [email protected]

Powered by socket.dev

socket-security[bot] avatar Jan 03 '23 08:01 socket-security[bot]

Let's get this in to avoid all the conflicts with the lock file. The new API will live in its folder, so we should be OK working on the main.

Again to be clear, this is going to be a fast-forward merge, DO NOT land this PR.

raisedadead avatar Feb 13 '23 16:02 raisedadead

And it exploded. Lol. I will take a look.

raisedadead avatar Feb 13 '23 16:02 raisedadead

The tests are failing because jest is picking up the .test.ts files in the API folder; it needs to be ignored for now (if we do not intend on using jest).

@ShaunSHamilton how do you want to proceed?

raisedadead avatar Feb 13 '23 18:02 raisedadead

The tests are failing because jest is picking up the .test.ts files in the API folder; it needs to be ignored for now (if we do not intend on using jest).

@ShaunSHamilton how do you want to proceed?

#49371

ShaunSHamilton avatar Feb 13 '23 19:02 ShaunSHamilton