freeCodeCamp icon indicating copy to clipboard operation
freeCodeCamp copied to clipboard

fix(curriculum): build a city skyline instruction updated

Open nayabatir1 opened this issue 2 years ago • 9 comments

…kyline instruction updated

Checklist:

  • [x] I have read freeCodeCamp's contribution guidelines.
  • [x] My pull request has a descriptive title (not a vague title like Update index.md)
  • [x] My pull request targets the main branch of freeCodeCamp.
  • [x] I have tested these changes either locally on my machine, or GitPod.

Closes #47555

nayabatir1 avatar Oct 12 '22 17:10 nayabatir1

gitpod-io[bot] avatar Oct 12 '22 17:10 gitpod-io[bot]

:eyes: Review this PR in a CodeSee Review Map

View the CodeSee Map of this change

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map Legend

ghost avatar Oct 12 '22 17:10 ghost

Hey @Sembauke what do you mean by fcc style? Can you share some examples for reference

nayabatir1 avatar Oct 13 '22 09:10 nayabatir1

Can you please use a descriptive title? the title of the issue is not a descriptive title for the PR

ilenia-magoni avatar Oct 13 '22 15:10 ilenia-magoni

@ieahleen can you pls confirm, is it appropriate ?

nayabatir1 avatar Oct 13 '22 17:10 nayabatir1

And to add to that, it was decided to not divide in three steps, but to make the stepp less 'handolding', with the wording mentioned in https://github.com/freeCodeCamp/freeCodeCamp/issues/47555#issuecomment-1275090120

ilenia-magoni avatar Oct 13 '22 17:10 ilenia-magoni

@ieahleen I've updated the pr. Do let me know if I missed anything.

nayabatir1 avatar Oct 13 '22 17:10 nayabatir1

Please follow the decision in the issue, do not do random changes

tbh I copied the changes from here, as you mentioned hints should be displayed when test fails image

nayabatir1 avatar Oct 14 '22 09:10 nayabatir1

That was the breakdown for splitting the challenge in three different steps, as it's not what it was decided to do, you don't need to take that wording

the hints there would be for the three steps

ilenia-magoni avatar Oct 14 '22 09:10 ilenia-magoni