freeCodeCamp icon indicating copy to clipboard operation
freeCodeCamp copied to clipboard

Published 20 hours ago • verified publisher icon freeCodeCamp

user text and user user is too close to the user's avatar.

Open staranbeer opened this issue 2 years ago • 6 comments

Describe the Issue

The profile summary page on the freecodecamp's forums have the user's avatar right next to the user's information which is a little too close in my opinion.

Affected Page

https://forum.freecodecamp.org/u/staranbeer/summary

Steps to Reproduce

  1. Go to '...'

https://forum.freecodecamp.org/u/staranbeer/summary

Expected behavior

Some spacing between the elements would be better.

Screenshots

Screenshot from 2022-07-28 00-14-52

System

  • Device: Laptop
  • OS: Ubuntu 20.04
  • Browser: Firefox

Additional context

No response

staranbeer avatar Jul 27 '22 18:07 staranbeer

Note - we don't write the forum software, so I don't think we can change this

It looks like when the green border for online users is added, the distance between the text and the user photo actually decreases. That feels like a Discourse bug.

jeremylt avatar Jul 27 '22 19:07 jeremylt

so we have no control over how the site the user profile looks? is there nothing we can do?

staranbeer avatar Jul 27 '22 19:07 staranbeer

there is a forum theme https://github.com/freeCodeCamp/forum-theme I don't know if the customization allowed by the Discourse software would allow to make this change tho

ilenia-magoni avatar Jul 27 '22 19:07 ilenia-magoni

Yup - while the platform is hosted by Discourse, we do have the ability to use our theme on top of it for visual things.

Interested contributors should look at the theme shared in the previous comment. There is documentation on how you can test changes as well.

raisedadead avatar Jul 29 '22 07:07 raisedadead

Hey! @raisedadead i actually tried looking for the particular CSS rules that are being used to style the user summary, but i couldn't find anything from the repo that @ieahleen mentioned.

staranbeer avatar Jul 29 '22 11:07 staranbeer

You should reach out to the contributor's chat for more help. Goodluck.

raisedadead avatar Jul 29 '22 13:07 raisedadead

@staranbeer, here is the file that needs changing: https://github.com/freeCodeCamp/forum-theme/blob/main/common/common.scss

Mind, you would need to change the styles for the signed in users.

ahmaxed avatar Aug 03 '22 08:08 ahmaxed

@staranbeer Thanks for working on this issue. Your proposed solution resolves the issue with minor changes. Therefore, I am closing this issue accordingly. https://github.com/freeCodeCamp/forum-theme/pull/74 Thank you for your contribution.

ahmaxed avatar Aug 08 '22 13:08 ahmaxed

Thanks! let me know if you have anything to work on or me! i would love to help in any way i can.

staranbeer avatar Aug 08 '22 14:08 staranbeer