freeCodeCamp icon indicating copy to clipboard operation
freeCodeCamp copied to clipboard

[i18n] Chinese motivational and congratulatory quotes are in English

Open moT01 opened this issue 3 years ago • 17 comments

Congratulatory quote at the top of the image: Screen Shot 2021-03-16 at 1 25 53 PM

Motivational quote when on Chinese /learn: Screen Shot 2021-03-16 at 3 21 24 PM

The file that holds these quotes is here. It'd be nice to get a few translations in there. Unless something has changed, this doesn't have to be a translation of the English version and the arrays don't need to be the same length. So maybe if we could get 10 or so of each type in there - more would be better, but 10 is probably enough to start.

moT01 avatar Mar 16 '21 20:03 moT01

Yeah those were just placeholders. The idea was to have some actual quotes from each language instead of translations of the quotes as they may be lost in translation.

RandellDawson avatar Mar 16 '21 20:03 RandellDawson

Translation of these quotes is currently underway and is being discussed here: https://github.com/freeCodeCamp/news-translation/issues/402

leonfeng avatar Apr 08 '21 09:04 leonfeng

Awesome, thanks for the update @leonfeng

I can't see an obvious way to make use of Crowdin for this. So, as a general approach, could we ask proofreaders to take a look and come up with some appropriate replacements? i.e. what @leonfeng is doing, but for other languages. @miyaliu666 @RafaelDavisH what do you think?

ojeytonwilliams avatar Apr 08 '21 10:04 ojeytonwilliams

@ojeytonwilliams Sure thing :)

leonfeng avatar Apr 08 '21 12:04 leonfeng

Thank @leonfeng for translating the quotes. I'll do proofreading soon. As you mentioned on the Chinese forum there were some mistakes in the English version, could you create an issue, so we can modify them before translating? Thanks again!

@ojeytonwilliams We discussed about proofreader onboarding for other languages. I think @raisedadead will share a plan later. Each language should have more than one proofreader, then they can translate and review the PRs just like we do for the Chinese version. Does it make sense?

miyaliu666 avatar Apr 11 '21 09:04 miyaliu666

We discussed about proofreader onboarding for other languages. I think @raisedadead will share a plan later. Each language should have more than one proofreader, then they can translate and review the PRs just like we do for the Chinese version. Does it make sense?

It does, that makes perfect sense. Thanks, Miya.

ojeytonwilliams avatar Apr 12 '21 08:04 ojeytonwilliams

@miyaliu666 Here it is: https://github.com/freeCodeCamp/freeCodeCamp/issues/41769

The fact-checking is rather slow going though, as I'm literally Googling the quotes one by one... Any idea how we can open this up to contributions (assuming anyone else is interested)?

leonfeng avatar Apr 12 '21 23:04 leonfeng

Hey @miyaliu666 where are we at with this?

naomi-lgbt avatar Aug 31 '21 14:08 naomi-lgbt

Let me review this later this week. Thanks! @nhcarrigan

miyaliu666 avatar Sep 02 '21 04:09 miyaliu666

{
      "quote": "Whatever you are, be a good one.",
      "author": "Abraham Lincoln"
    }
可以是 

{ "quote": "但行好事,莫问前程", "author": "增广贤文" }

     {
      "quote": "It does not matter how slowly you go as long as you do not stop.",
      "author": "Confucius"
    },
    {
      "quote": "Real knowledge is to know the extent of one's ignorance.",
      "author": "Confucius"
    },
    {
      "quote": "The past cannot be changed. The future is yet in your power.",
      "author": "Confucius"
    },

应该是

     {
      "quote": "譬如为山,未成一篑,止,吾止也。譬如平地,虽覆一篑,进,吾往也.",
      "author": "孔子"
    },
    {
      "quote": "知之为知之,不知为不知,是知也",
      "author": "孔子"
    },
    {
      "quote": "往者不可谏,来者犹可追",
      "author": "孔子"
    },
{
      "quote": "A good traveler has no fixed plans and is not intent on arriving.",
      "author": "Lao Tzu"
    },
    {
      "quote": "An ant on the move does more than a dozing ox.",
      "author": "Lao Tzu"
    },
    {
      "quote": "Do the difficult things while they are easy and do the great things while they are small. A journey of a thousand miles must begin with a single step.",
      "author": "Lao Tzu"
    },

应该是(第二个找不到合适的)

{
      "quote": "善行无辙迹,善言无瑕谪",
      "author": "老子"
    },
    {
      "quote": "上士闻道,勤而行之",
      "author": "老子"
    },
    {
      "quote": "天下难事,必作于易,天下大事,必作于细;千里之行,始于足下",
      "author": "Lao Tzu"
    },

lijiang2014 avatar Oct 21 '21 02:10 lijiang2014

谢谢 @lijiang2014。这么一看,我们的古文确实很有味道啊!你可以参考这里的说明提出翻译建议,后续我们汇总创建一个 PR。

也谢谢 @leonfeng 耐心等待!其实我看了很多次你的翻译,想要校对,但是我也拿不准。特别是鼓励语部分,虽然句子总数不多,但是有些可能是来源于动漫?

miyaliu666 avatar Oct 21 '21 04:10 miyaliu666

Sorry, I communicated in Chinese here and just realized it. I'll review the translations above asap. Thanks for your patience!

miyaliu666 avatar Oct 22 '21 02:10 miyaliu666

bump

moT01 avatar Mar 24 '22 19:03 moT01

I wonder if we should promote this somehow. I'm wondering if people don't realize these need to be translated/created. Looks like a few of the languages have added localized quotes - but many haven't, it's not just Chinese. Maybe we should just add them to crowdin.

moT01 avatar Mar 24 '22 19:03 moT01

The concern with adding them to Crowdin was that not all quotes/phrases are going to make sense culturally.

That is, these shouldn't be one-to-one translations - each language should select their own relevant quotes and phrases to use.

naomi-lgbt avatar Mar 24 '22 20:03 naomi-lgbt

@miyaliu666 if these quotes are good can we get them added?

naomi-lgbt avatar Jul 06 '22 14:07 naomi-lgbt

Can you wait for another week, so I can review them and translate the rest after finishing the translation of the first curriculum? Thanks for your huge patience! @nhcarrigan

miyaliu666 avatar Jul 07 '22 07:07 miyaliu666