devdocs icon indicating copy to clipboard operation
devdocs copied to clipboard

Remove the "::" separator from the SEPARATORS_REGEXP in searcher.js

Open chaitanyarahalkar opened this issue 9 months ago • 2 comments

Should fix #2463

Tried searching for std::min and was able to get good C++ documentation results.

The issue was in the search query normalization process. When you searched for "std::min", the "::" (scope resolution operator in C++) was being replaced with a separator character, which prevented the search from matching C++ symbols correctly.

I removed the "::" pattern from the SEPARATORS_REGEXP regular expression in the searcher.js file. This change allows the search functionality to preserve the C++ scope resolution operator (::) when processing search queries.

chaitanyarahalkar avatar Mar 31 '25 00:03 chaitanyarahalkar

@simon04 let me know if this change looks good. Ty!

chaitanyarahalkar avatar Apr 13 '25 01:04 chaitanyarahalkar

Hi, thank you for this PR. I have troubles understanding the practical benefit when not considering :: as a separator. The given example std::min works just fine at the moment? Are there other search inputs that benefit from removing :: as a separator?

simon04 avatar Apr 18 '25 17:04 simon04