devdocs icon indicating copy to clipboard operation
devdocs copied to clipboard

add Sanctuary

Open davidchambers opened this issue 3 years ago • 2 comments

If you’re adding a new scraper, please ensure that you have:

  • [x] Tested the scraper on a local copy of DevDocs
  • [x] Ensured that the docs are styled similarly to other docs on DevDocs
  • [x] Added these files to the public/icons/sanctuary/ directory:
    • [x] 16.png: a 16×16 pixel icon for the doc
    • [x] [email protected]: a 32×32 pixel icon for the doc
    • [x] SOURCE: A text file containing the URL to the page the image can be found on or the URL of the original image itself

Is it possible to specify the href values used in the sidebar? I would like to use /sanctuary/#map, for example, in place of /sanctuary/index#map.

Many thanks to @jceb and @identinet for sponsoring this work! :beers:

davidchambers avatar Jul 03 '22 17:07 davidchambers

@simon04, might you be able to review this pull request? :)

The test failures are misleading: I intentionally overrode entries_as_json and types_as_json to preserve ordering.

davidchambers avatar Jul 22 '22 11:07 davidchambers

Tests are now passing. :)

davidchambers avatar Aug 05 '22 09:08 davidchambers

I would love to see this pull request merged. I spent two days preparing it.

Is there something I can do to make the changes easier to review, @simon04? :)

davidchambers avatar Aug 25 '22 09:08 davidchambers