smf icon indicating copy to clipboard operation
smf copied to clipboard

Fix: Raise Error Log when Uplink/Downlink AMBR missing unit

Open ntut-xuan opened this issue 7 months ago • 0 comments

What's happened?

Hi, I'm Uriah from NYCU Room 217 😄

In this PR, I fix when Uplink/Downlink AMBR in webconsole subscriber page doesn't have unit, it will rasie panic in free5gc SMF.

image

In above image, the Uplink/Downlink AMBR doesn't have unit (Mbps or Kbps), it will make free5gc raise panic in below image.

image

I add error handling in BitRateTokbps function and raise Error in ActivateTunnelAndPDR function when BitRateTokbps function raise the error.

image

Implmentation

  • [x] Add error handling in ActivateTunnelAndPDR

How to review?

  • Check when Uplink/Downlink AMBR doesn't have unit, it should raise error instead of raw panic.

ntut-xuan avatar Jul 30 '24 06:07 ntut-xuan