sql_exporter icon indicating copy to clipboard operation
sql_exporter copied to clipboard

Add snowflake support

Open masch712 opened this issue 4 years ago • 9 comments

Simply adding support for the Snowflake driver. I hope I added the dependency correectly.

masch712 avatar May 10 '20 11:05 masch712

Think we could get this merged soon? I would love to be able to use the official sql_exporter image rather than have to build from source and host my own...

nomeelnoj avatar Sep 09 '20 23:09 nomeelnoj

Hi @free, it sounds like there's at least two parties looking for this feature. Need anything else from me to facilitate reviewing this PR?

masch712 avatar Sep 11 '20 23:09 masch712

Hey @free! Any updates here? Would really love to be able to use the hosted sql_exporter image. Please let me know if there is anything you need from me to help get this pushed through and a new release cut!

nomeelnoj avatar Jan 24 '21 07:01 nomeelnoj

Hey @free, @burningalchemist. It looks like maybe this repo is losing support, as it has not been updated in quite some time now. Is there anything we can do to help support it? I know this is a widely used tool in various locations, but we are in a place where im guessing most people are forking and managing their own, versus just using the open source version.

What can we do to get some of these PRs approved/merged?

nomeelnoj avatar Feb 25 '21 05:02 nomeelnoj

Hey @nomeelnoj, you can take a look at the fork I maintain for the moment: https://github.com/burningalchemist/sql_exporter

It's compatible, has some updates, and I keep using it myself, so happy to look into the issues, if there are any. It might be that at some point we can merge things back to the original repo, or maybe not. 🙂

If this works for you, give it a shot. 👍

burningalchemist avatar Feb 25 '21 06:02 burningalchemist

@burningalchemist thanks! ill definitely take a look. Seems that the original maintainers of sql_exporter have gone MIA...sadly.

nomeelnoj avatar Apr 09 '21 19:04 nomeelnoj

@nomeelnoj feel free to leave a comment, if there's an issue with it. 👍 I updated the latest snowflake driver version recently.

It's a bit tricky to test it with snowflake without creating an account, but I'm happy to look into it if anything. 🙂

burningalchemist avatar Apr 09 '21 19:04 burningalchemist

why is this not merged? we are currently using it, and works as expected.

serratala avatar Mar 08 '22 00:03 serratala

Any update on this? Why has it not been merged?

jnovick avatar Feb 18 '24 12:02 jnovick