prometheus icon indicating copy to clipboard operation
prometheus copied to clipboard

bring x-rate upstream

Open roidelapluie opened this issue 3 years ago • 8 comments

Hello,

I'd like to know if you would be interested into bringing x-rate upstream in Prometheus, behind a feature flag? Exact details would be TBD, but we are open to this idea and would welcome a formal proposal to move forward in this direction.

if you want to contribute it, we could re-analyze your proposals with a fresh eye and find the best outcome for the community.

thanks!

roidelapluie avatar Oct 07 '21 23:10 roidelapluie

Hey Julien,

Yeah, totally! I'm a bit rusty on Golang (haven't really coded anything in almost 2 years), but the concept and implementation are pretty simple, so I'm happy to give it a go.

Let me know what you need and I will try to oblige.

Cheers!

free avatar Oct 08 '21 09:10 free

For now the idea would be to put the approaches described in the upstream issue in a clear google doc instead of a github issue. once it is done, we can start discussing a bit easily.

Note that I want to solve this issue, so the goal is really not to make you lose your time; the goal is to have this actually implemented quite soon.

roidelapluie avatar Oct 08 '21 11:10 roidelapluie

Should I go ahead and start that document (when I can find the time) or would you do it? (E.g. if there's some structure / process it must follow rather than a free-form proposal.)

free avatar Oct 08 '21 12:10 free

I have shared an empty design doc with you, you should be able to use it and move forward. Thanks

roidelapluie avatar Oct 08 '21 13:10 roidelapluie

Finally found the time to go through the whole document. I had to rush through it towards the end (or it might have taken me another month to get back to it) but I believe I've done a mostly decent job.

Will try to address any comments as they come, but it may take some time to do so.

free avatar Nov 08 '21 22:11 free

Thanks a lot!

roidelapluie avatar Nov 08 '21 22:11 roidelapluie

Did another pass a few days ago, please let me know if you need anything specific on my part.

free avatar Nov 25 '21 10:11 free

@roidelapluie ? :)

sylr avatar Dec 14 '21 17:12 sylr