Alin Sinpalean

Ouch, that would appear to be my fault. Initially SQL Exporter used a [configuration-provided query timeout](https://github.com/free/sql_exporter/blob/master/config/config.go#L141) and when I found out about Prometheus' `X-Prometheus-Scrape-Timeout-Seconds` header (which informs targets about its...

> Perhaps having it default to unlimited, so Prometheus' scrape_timeout is the master would be more intuitive? That's what I thought too, but it may not be the best idea...

10 seconds is actually the default [hardcoded](https://github.com/free/sql_exporter/blob/802289bb112f06a3dcb20e5e5f8b6f30793bf195/config/config.go#L155) into SQL Exporter. There's no need to put it in the YAML config.

I can only venture a guess, based on my previous experience with MSSQL (I used to maintain the jTDS JDBC driver back in the day). MSSQL stored procedures may return...

Apologies for the delay. Would it be possible to have a test for this? May also be useful as documentation.

> Sure. Do you have a template for this? I can't seem to find any tests in the repo. Yeah, that's because there aren't any. )o: But it's never too...

Why not apply the "static label per DSN" in the Prometheus config? Something like this: ```yaml scrape_configs: - job_name: 'somedb' static_configs: - targets: [ 'instance1.cluster13.foo.org:9399', 'instance2.cluster13.foo.org:9399' ] labels: cluster_identifier: cluster13...

Sounds like a really good idea. I'll implement it when I have the time, it will require a bit of (much needed) refactoring.

SQL Exporter is stateless. Every time it is scraped by Prometheus it queries the DB for metric values. (A counter also implies state, but we're relying on the DB for...

Done. With apologies for not even replying until now. There exists now a flag, `config.data-source-name`, which will override the value of `target.data_source_name`, as defined in the configuration file. Note that...