clap-wrapper icon indicating copy to clipboard operation
clap-wrapper copied to clipboard

Wrapper sets `_host->version` to the plugin version not the host version

Open baconpaul opened this issue 1 year ago • 4 comments

In short circuit I construct my clap about screen this way (in my local branch - merging soon)

engine->runningEnvironment =
        "Clap-First " + std::string(h->name) + " " + std::string(h->version);

where h is my clap_host_t * passed in at construction. Fine.

The CLAP in bitwig shows this

Screenshot 2024-08-14 at 9 47 09 AM

The VST3 wrapped in bitwig though shows this

Screenshot 2024-08-14 at 9 47 25 AM

(0.7.225.0 is my plugin version number)

and the AUv2 wrapped in logic shows the same

Screenshot 2024-08-14 at 9 48 00 AM

(once I merge #286 to remove the specious -wrapper string)

so I think we need to go and use the protocols to find the running host version and report it if possible. Or at least report the clap wrapper version rather than the plugin version.

baconpaul avatar Aug 14 '24 13:08 baconpaul

Note that the AUv2 adds (6029) which is the logic application bundle to the host name before the (CLAP-as-AUv2)

And we probably want some build option to make those terser perhaps?

baconpaul avatar Aug 14 '24 13:08 baconpaul

Those strings are actually only in debug builds.

defiantnerd avatar Aug 14 '24 14:08 defiantnerd

Are you sure? I think you are confusing the plugin name with the clap _host->name

https://github.com/free-audio/clap-wrapper/blob/48861ecf472fe2cbcd67478e3f5f0dabe9e5785c/src/detail/auv2/auv2_base_classes.h#L462

that's not debug guarded

https://github.com/free-audio/clap-wrapper/blob/48861ecf472fe2cbcd67478e3f5f0dabe9e5785c/src/wrapasvst3.cpp#L1083

and neither is that. And I just did a release build and the screen for the VST3 was unchanged

baconpaul avatar Aug 14 '24 14:08 baconpaul

I think the right solution here is probably a clap wrapper host information extension. Let me ponder that a bit.

baconpaul avatar Aug 14 '24 15:08 baconpaul