clap-wrapper icon indicating copy to clipboard operation
clap-wrapper copied to clipboard

MSVC compiler warnings

Open baconpaul opened this issue 2 years ago • 4 comments

in #81 we turned on -Wall -Wextra -Wpedantic -Werror for GCC and CLang

We have not done this for MSVC. We should do that for sure one day soon!

baconpaul avatar Sep 08 '23 12:09 baconpaul

Which compiler flags do we want exactly:

  • /W4 Enable warning level 4 or even /Wall?
  • /WX Treat warnings as errors

-Wextra and -Wpedantic have no equivalent in Visual Studio.

defiantnerd avatar Jan 27 '24 17:01 defiantnerd

I have absolutely no idea! :)

baconpaul avatar Jan 27 '24 19:01 baconpaul

I have enabled them for a test and there are a few issues we need to solve first. Interesting enough, those issues should have been detected by GCC/Clang, too. ??

defiantnerd avatar Jan 27 '24 20:01 defiantnerd

Yeah its nice to have multiple compilers so you can get the varied warnings!

baconpaul avatar Jan 27 '24 21:01 baconpaul