clap-plugins icon indicating copy to clipboard operation
clap-plugins copied to clipboard

Update build.sh

Open tarnith opened this issue 2 years ago • 3 comments

Moved the hardcoded directory to at least C;\temp so the chance of overwriting existing files is reduced. Perhaps a check for existing directores before wiping data would be advised.

tarnith avatar May 04 '23 20:05 tarnith

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar May 04 '23 20:05 CLAassistant

Did you confirm that the path was short enough to build qt using vcpkg?

abique avatar May 05 '23 09:05 abique

Can't confirm as can't complete build due to other build errors.

Perhaps a better PR would be a simple if [ -d "/path/to/directory" ]; then echo "Directory exists. Delete or choose another buildtree" break

I notice some other build scripts also hard code C:\B which is unfortunately a preexisting folder on my system for other things requiring a short path. vcpkgerror.log

tarnith avatar May 05 '23 18:05 tarnith