roundabout icon indicating copy to clipboard operation
roundabout copied to clipboard

with jQueryUI animation broken again

Open WLL70 opened this issue 12 years ago • 10 comments

if you take your sample demo page

http://fredhq.com/projects/roundabout/demos/standard

and add

http://code.jquery.com/ui/1.9.2/jquery-ui.js

to the page and BOOM doesn't rotate any longer.

You are using jQuery Roundabout - v2.1.1 in your demo so i tried both that and your latest v2.4.2 still no dice.

PS: Great plugin

WLL70 avatar Dec 17 '12 18:12 WLL70

check this issue - worked for me https://github.com/fredhq/roundabout/issues/72

mschel avatar Jan 09 '13 19:01 mschel

Seeing the same issue with 1.10.1 jquery ui. removing the ui library results in the roundabout working

kwilsbach avatar Feb 28 '13 20:02 kwilsbach

Line 693 reads:

if (methods.compareVersions.apply(null, [$().jquery, "1.7.2"]) >= 0 && !($.easing["easeOutBack"])) {

if you change this to

if (true) {

it works just fine.

I don't think there is a need for the compareVersions function any more, perhaps a specific "if version is(not) ..*"

kwilsbach avatar Feb 28 '13 20:02 kwilsbach

Thanks Kwilsbach, this is working perfectly fine for me!

jonathanjto avatar Mar 04 '13 16:03 jonathanjto

Thanks kwilsbach for the fix !

drdeteck avatar Apr 06 '13 02:04 drdeteck

Absolute life saver Kwilsbach, this issue pretty much blows the otherwise awesome plugin up. Can confirm the suggested fix by Kwilsbach, above works perfectly!

peterbrowse avatar May 20 '13 18:05 peterbrowse

Great, thank you for the fix!

kReEsTaL avatar May 22 '13 09:05 kReEsTaL

+1 on either removing this check, or improving it to work w/ the latest jquery + jquery ui libraries.

RobCherry avatar Jun 20 '13 17:06 RobCherry

using UI 1.10.3 not working for me ...

kaanozcan avatar Jul 04 '13 09:07 kaanozcan

I changed d.compareVersions.apply(null,[a().jquery,"1.7.2"])>=0&&!a.easing["easeOutBack"] with true and all works fine!

I noticed if you charge first jQuery UI than jQuery works the same (but obviously other javascript works bad)

http://code.jquery.com/jquery-1.10.2.min.js http://code.jquery.com/ui/1.10.3/jquery-ui.js jQuery Roundabout - v2.4.2

steno-baz avatar Jan 06 '14 18:01 steno-baz