roundabout
roundabout copied to clipboard
jQuery UI 1.8.23 => animation broken!
jQuery UI version from 1.8.23 till 1.9.0 animation broken! (jQuery 1.7.2. version)
I've found the same issue occurs with jQuery 1.8.2 and jQuery UI 1.9.1. I fixed it by changing the following line:
(around line 693, commented out easeOutBack check) if (methods.compareVersions.apply(null, [$().jquery, "1.7.2"]) >= 0 /&& !($.easing["easeOutBack"])/) {
Thanks noremacstew, this solved the problem for me too.
line 693, in which file? I searched for
if (methods.compareVersions.apply(null, [$().jquery, "1.7.2"]) >= 0 /&& !($.easing["easeOutBack"])/) {
in jquery, ui and roundabout and did not find it
For me it is line 693 of jquery.roundabout.js (v2.4.2).
The PHP comment you quoted around for the easeOutBack check was the change I made to fix the issue. Try searching for:
if (methods.compareVersions.apply(null, [$().jquery, "1.7.2"]) >= 0 && !($.easing["easeOutBack"]))
In my copy there is also this comment just above that line:
// fixes issue #24, animation changed as of jQuery 1.7.2 // also addresses issue #29, using easing breaks "linear"
Searching for those comments might lead you to the line I was referring to. Hope that helps!
I can't thank you enough for this fix!
Works for me on jquery-ui-1.9.2.custom.min.js (full) ; jquery-1.8.3.min.js and roundabout 2.4.2
Thanks a lot !