roundabout icon indicating copy to clipboard operation
roundabout copied to clipboard

Fix animations when using jQuery >= 1.7.2 and jQuery UI

Open RobCherry opened this issue 11 years ago • 5 comments

Fixes https://github.com/fredhq/roundabout/issues/61 https://github.com/fredhq/roundabout/issues/86 https://github.com/fredhq/roundabout/issues/87 and https://github.com/fredhq/roundabout/issues/106

RobCherry avatar Jun 20 '13 19:06 RobCherry

jQuery 1.8.3 and jQuery ui 1.9.2 animation didn't work :(

quietasice avatar Jul 12 '13 11:07 quietasice

Also it doesn't work with jQuery UI 1.10.3. Is there any solution ?

DonDi1989 avatar Oct 21 '13 07:10 DonDi1989

I got it working with jQuery UI 1.10.3:

First, apply the fix reply #95 in so the "focus" event fires again reply 3 by @jellever

Then change the following 3 lines (line 693 - 697 in version https://github.com/fredhq/roundabout/blob/d8cc98ccc0e214514cfe76fe4c1a9d8a99a50c6b/jquery.roundabout.js)

if (true) {
  newBearing = passedData.start + ((bearing - passedData.start) * newBearing);
}

// newBearing = methods.normalize.apply(null, [newBearing]);

The newBearing was set to 0 with without these changes. Did this for a quick workaround - it requires more digging to fix the root cause.

jonaslu avatar Oct 31 '13 15:10 jonaslu

@jonaslu Just ran into this and that hack works great, thanks. :)

kitsunde avatar Feb 06 '14 06:02 kitsunde

@jonaslu thanks, it worked (even without the fix in #95) I'm using jquery 1.10.1 and jquery UI 1.10.3

JorisLambrechts avatar Mar 20 '14 10:03 JorisLambrechts