A. Jiang

Results 235 comments of A. Jiang

LLVM-77948 is merged. I guess this issue can be closed by the next LLVM submodule update.

> [ ] What's causing this `_CrtIsValidHeapPointer` assertion, which is the underlying spurious failure? I believe this is #4268. (The `public_setg` function calls `setg`, and then changes the return value...

Some thoughts on implementation details. For iterator types: - `iterator` and `const_iterator` shouldn't be dependent on `key_compare`. - The use of `zip_view` can be avoided. - If `iterator` is denoted...

> Thanks @frederick-vs-ja for sharing her/his/their insights. I briefly read the implementation of `ranges::zip_view::iterator`. Here are my thoughts on `flat_map::iterator`: > > * Suppose `iter` is a `flat_map::iterator`, then `*iter`...

> Do these control blocks need new visualizers? I'm now trying to add visualizer for `_Ref_count_obj_alloc_for_overwrite`. ~But visualization of control block types for array types still seems missing and I...

Currently, both checked and unchecked iterators of MSVC STL's `deque` add one more layer of indirection. It seems that we can add simpler iterator types that hold the `_Mapptr` and...

It seems intentionally allowed to define `exception_ptr` in another namespace (and with a possibly differerent name) and then drag it into `std` by `using`/`typedef`, which can sightly improve throughput since...

> I don't immediately know whether this will need to be implemented in the UCRT. It seems to me that UCRT should implement the change ([WG14-N2829](https://www.open-std.org/jtc1/sc22/wg14/www/docs/n2829.htm)). Note that the change...

VSO-1601168 ("EDG's `__builtin_memcmp` emits bogus errors with move-constructed strings and constexpr dynamic allocations") seemly should also be tracked here. It was discovered in #3057.

Perhaps the use of `_Defaultabox` in `join_view`'s iterator is also problematic, and we should completely get rid of `_Defaultabox`. Edit: yes, these 3 tests pass if we change to use...