Hardware-Target-Game-Database
Hardware-Target-Game-Database copied to clipboard
frederic-mahe
Fix naming of a few @Place files.
A few @Place files are incorrectly named, and one probably shouldn't be there at all.
@hotelvictorcharlie If we're going to remove the MSX placeholder (which is the only file here in the Games/MSX directory), then why not remove the sole placeholder for Games/SNES and others like it too?
@hotelvictorcharlie If we're going to remove the MSX placeholder (which is the only file here in the Games/MSX directory), then why not remove the sole placeholder for Games/SNES and others like it too?
I guess I'm thinking there's a difference between a placeholder for a MiSTer add-on pack vs. a placeholder for a non-MiSTer pack (such as SNES). None of the other add-on packs have placeholders, so I am assuming that it's sort of implied that you're supposed to just dump whatever add-ons you want into the MiSTer games directory.
The MSX add-on is also a weird case because it contains a config file that isn't supposed to go inside the Games/ directory (though maybe that config file should just be part of the main MiSTer pack, like the ones for Archie etc.).
As another side note, some of the other consoles supported by MiSTer don't seem to have placeholders that they should have (GBA, Atari 7800, etc.) so maybe we should add them?
There was a suggestion that we should think about revamping the way MiSTer add-on packs are handled. Maybe it would make everything a lot simpler to just have all the add-ons live inside the MiSTer pack. What do you think?
Having all the add-ons live inside the MiSTer pack makes it much more unwieldy to manage, especially since each may have a different source for validation and datting purposes. Perhaps not a bad idea to add more placeholders with the correct directory names expected by the MiSTer cores.
Some of the add-on packs only have a very small number (1-5) of files in them (ao486, TSConf, MSX) so I think we could at least put those ones into the main MiSTer pack without it getting unwieldy, right?
As for the others, what if we convert them into standalone packs that can be referenced via placeholders from any pack? This could prove useful if we want to create a pack for e.g. the Analogue Pocket (which, as the owner of a Pocket, I think we definitely should 😄 ). Also it would be a good opportunity to close #717 and #718.
Having all the add-ons live inside the MiSTer pack makes it much more unwieldy to manage, especially since each may have a different source for validation and dating purposes. Perhaps not a bad idea to add more placeholders with the correct directory names expected by the MiSTer cores.
I agree. We need more placeholders, for example for the Intellivision, or for the Atari 2600 (although there seems to be a set of 'MiSTer Fixed' ROMs for the Atari 2600. I don't know if this is still relevant).
The "MiSTer Fixed" entries should be reviewed. Most likely they match no-intro now.
Fixed via https://github.com/frederic-mahe/Hardware-Target-Game-Database/pull/971