Fred Emmott

Results 502 comments of Fred Emmott

Thanks - also repros on our internal builds which is helpful. Filed FB T91160732 for this

Thanks; filed internally and assigned to on-call - T90315482 for our reference

Sorry, we don't really have good next steps: the leak is very small, which makes it difficult to track down; it's unlikely we're going to be able to dedicate more...

- Add tests to runtime (hphp/test/slow) and typechecker (hphp/hack/test/) - Make that change to the HHI - If runtime tests fail (unlikely), make a similar change to the runtime (probably...

1. can you file an issue against docs.hhvm.com? 2. https://www.php.net/manual/en/language.errors.php7.php is a good overview; in short, Error is used instead of the PHP5 error reporting mechanism for builtin errors. HHVM...

There have been some discussions about if `HH\Asio\curl_exec()` is: - sound - actually useful: given the thread overhead, curl_multi_exec() + `await HH\Asio\usleep()` can actually be more efficient It *might* be...

So, that expected result isn't going to happen, regardless of what's done for async - e.g. this has the huge wait between printing 1 and 2: ```

There's `hh_client --type-at-pos` too, but yes, this is useful. We have something very similar already in `hh_single_type_check` (used for our unit tests): a fake function called `hh_show()` that pretty much...

2 should be identical to 1, unless 1 is not denotable at all. If we did do a separate (2) it'd be something like `HH\show_unsafe_more_permissive_denotable_type_and_error()`, though I don't know if...

Thanks; I think this is a previously unknown bug from our perspective - filed FB T106916441