Fredrik Adelöw

Results 369 comments of Fredrik Adelöw

Linking in #18372 for context, tangentially related

@alexlorenzi ping us somewhere if you need help reopening stuff

Indeed. For the interested reader, [here](https://github.com/backstage/backstage/blob/40c96b1562a27e5e73fab1a44ac3ff34f48a4c50/packages/core-components/src/components/TabbedLayout/RoutedTabs.tsx#L83) is the click handler, and the underlying tab bar [uses](https://github.com/backstage/backstage/blob/40c96b1562a27e5e73fab1a44ac3ff34f48a4c50/packages/core-components/src/layout/HeaderTabs/HeaderTabs.tsx#L18) plain MUI `Tabs` and `Tab`. We have some faint memory of this having some...

@JeevaRamanathan Am I understanding your screenshots correctly that they don't show any issue after the fix? If so, we would be happy to review a PR for it.

Yep see my comment above regarding indices of string values in both pg and mysql. For fixes, I'd say, either introduce hashing of refresh keys (maybe only over a certain...

Oof - thanks for reporting, of course this should work and I always do the same. That library has been a bit less than stellar, I wonder if there are...

One issue iirc is that there's a lot of code that just uses git-url-parse or things like [resolveUrl](https://github.com/backstage/backstage/blob/master/packages/integration/src/types.ts#L50) that aren't even async in the first place so there's very little...