Fredrik Adelöw

Results 369 comments of Fredrik Adelöw

esm only https://github.com/backstage/backstage/pull/23114

Total side note @aramissennyeydd - that was [actually meant](https://github.com/backstage/backstage/blob/master/docs/architecture-decisions/adr013-use-node-fetch.md) to use `node-fetch` :) Not that it makes a huge difference in practice.

For backend, yeah. The deal for the catalog has been - in the frontend, inject fetchApi (whatever it happens to use under the hood, which likely is the native browser...

As _which_ particular fetch? ;) yeah I see the catalog client actually uses global.fetch [as its input type](https://github.com/backstage/backstage/blob/25adbdde2d1e65577b600074163d5ddb6858752f/packages/catalog-client/src/CatalogClient.ts#L59) but uses cross-fetch as the default actual fallback implementation

The BEP explicitly calls out [in its non-goals section](https://github.com/backstage/backstage/blob/master/beps/0003-auth-architecture-evolution/README.md#non-goals) that it does not aim to make room for the ability to change out the Authorization header as the carrier. One...

> @freben Thoughts on a new `eventSourceApi` that uses `EventSourcePolyfill` under the hood for `plugins/catalog` and `plugins/scaffolder` (to be used for other SSE's as well)? Hm maybe. The usages are...

@kuangp Alright! But in its current shape in the PR, does it look the way you wanted it to? It's green at least :)

Preface: this is just a brain dump, not discouragement at all :) In a sense, this would be another one among many many "unifying" abstractions that have been, and will...

Seems promising, but it also seems to have triggered some form of CI error!

I rudely added a comment to that effect to get the change in for the release! Hope that's OK.