Fredrik Adelöw

Results 619 comments of Fredrik Adelöw

Do you have a particular use case in mind where this cache would be particularly effective? Or put differently, do you have a reproduction scenario to look at, where the...

Thanks, that makes sense and helps to have as an example use case when someone tries to implement it.

@drodil Were you meaning to put those comments on #22594 or somewhere like that? Maybe I'm misunderstanding EDIT: (and it's looking awesome obviously) DOUBLE EDIT: Haha ok I apparently skipped...

Hi! Sorry but there's a conflict now.

Sorry but there are conflicts. Maybe after the release tomorrow there'll be some more - could rebase after that perhaps

The control [ensures](https://github.com/backstage/backstage/blob/bb48b3fd5e92fc913162cf881237e3ede3852f7e/plugins/catalog-react/src/components/EntityKindPicker/EntityKindPicker.tsx#L117) that whatever's the current filter setting is available in the dropdown, whether it's otherwise an existing possible pick or not. I think that that makes a lot...

Sorry that this is taking time. You've caught me in a pretty bad time, with KubeCon/BackstageCon, a large and important release, and PTO time all conspiring to make the review...

Hey, sorry but a rebase is needed

Sure, the means of installation would definitely change either way down the line. The fact that it's implemented as a processor now was meant to be transparent, but waiting for...

🛑 blocking this a bit to follow up on https://github.com/backstage/backstage/pull/17125 first