justintv-stream-notifications
justintv-stream-notifications copied to clipboard
Update interval 0 triggers endless 429 requests
Thanks for the Add-on!
System Info
- Firefox Version: 73.0
- Extension Version: 3.11.1
Steps to reproduce
- Hit the twitch api rate limit
- Set update interval to 0 in the preferences
- Watch the endless stream of 429 requests in the background network inspector
- (also hogs a fair amount of the CPU due to the endless requests)
Workaround: Set update interval to 4294967295
Solution: don't set it to 0 if you didn't expect it to keep updating forever and always.
Well, the description of that preference reads Interval of the addon checking wether a stream is live in seconds. When 0, the states aren't automatically updated
- so I was expecting that 0 disables the interval; or was that a misunderstanding?
Oh, you then indeed aren't.
It also seems that the update interval isn't respected when the Add-on initializes, e.g. on Firefox start it always refreshes the streams.
On related note: would be cool to have an option to refresh the streams when clicking the browser action (would spare one click on the refresh icon when disabling automatic refresh is preferred)