advanced-github-notifier icon indicating copy to clipboard operation
advanced-github-notifier copied to clipboard

Better the main icon

Open andry81 opened this issue 1 year ago • 4 comments

Describe the bug If switch to GitHub dark page color mode, then icon becomes barely visible. The same for the Firefox about:addons page.

Example:

To Reproduce Steps to reproduce the behavior:

  1. Switch GitHub/Firefox to dark page color mode.

Expected behavior Another older extension has an example of a better icon: https://github.com/sindresorhus/notifier-for-github

Example:

Firefox (please complete the following information):

  • OS: Windows 7 x64
  • Firefox Version: 103.0.2
  • Extension version: 1.10.0

andry81 avatar Aug 27 '22 13:08 andry81

The toolbar button should be switching to a light version for themes that declare themselves as dark (https://github.com/freaktechnik/advanced-github-notifier/blob/main/images/github-light.svg).

freaktechnik avatar Aug 28 '22 07:08 freaktechnik

The toolbar button should be switching to a light version for themes that declare themselves as dark (https://github.com/freaktechnik/advanced-github-notifier/blob/main/images/github-light.svg).

This is not the application icon.

andry81 avatar Aug 28 '22 09:08 andry81

@freaktechnik He is talking about https://github.com/freaktechnik/advanced-github-notifier/blob/main/images/icon.svg

add-on page

The dark blue plus sign of that icon is also not easy to distinguish from the black bell as well.

tooomm avatar Sep 11 '22 17:09 tooomm

The dark blue plus sign of that icon is also not easy to distinguish from the black bell as well.

It's not easy distinguish from the dark background either.

andry81 avatar Sep 12 '22 00:09 andry81