shopifyFD icon indicating copy to clipboard operation
shopifyFD copied to clipboard

Move to GitHub releases and add minification tool

Open Leland opened this issue 8 years ago • 1 comments

This is more of a proposal than an issue: have you considered moving to the GitHub release pattern?

Doing that, and then adding in a build tool (e.g. Gulp/Grunt) would allow you to both have more granular control over proper releases, and would allow you to remove the minified files from the repository.

If you're interested, I can create a quick POC as a fork.

Leland avatar Mar 30 '17 20:03 Leland

The minified version only exists in the repo since it was once directly linked to in the chrome extension. That was back when there was less than 100 users. Now the file is pulled from S3 and the Shopify CDN,

I keep it up to date whenever I push a new release but I don't need to throw gulp or grunt into the mix. We're only talking about a single JS file so the lack of build automation is only burning a few seconds each time.

May have worth for the next version since there may be more fingers in the dev cycles.

freakdesign avatar Apr 04 '17 09:04 freakdesign