shopify-custom-fields icon indicating copy to clipboard operation
shopify-custom-fields copied to clipboard

Empty Value Should Wipe Exisiting Value

Open chryton opened this issue 9 years ago • 5 comments

Been noticing that if I need to turn something "off" by removing a value from a field (such as making a text input empty) that does not save or remove the metafield.

The only way to do this would be to go into FD and remove the generated metafield.

This is overall slightly confusing user experience as why should a user have to use another too to just reset/remove a value from a field and leave that field blank?

chryton avatar Nov 29 '16 20:11 chryton

Thanks for the heads up.

I always thought that blanking the field did remove it, but it's possible that's all a dream. I wasn't planning on adding many more mods to this version, but this seems like a valid thing to add now.

freakdesign avatar Nov 30 '16 16:11 freakdesign

@freakdesign Just checking in to see if this has been investigated at all. Still running into the issue on stores.

If there was unminified/source code, I or someone on my team could help debug the issue and submit a PR.

chryton avatar May 25 '17 14:05 chryton

I tested this (briefly) and didn't see the same result. I followed these steps:

  • created a metafield on a collection using the extension
  • reloaded the collection (and ran the tool again)
  • double checked the metafield existed with ShopifyFD
  • cleared the field value in Custom Fields and saved
  • reloaded the collection (and ran the tool)
  • The field was empty and ShopifyFD reported no metafield.

I'd be curious to see if you still see this problem and what steps you take.

freakdesign avatar Jun 08 '17 17:06 freakdesign

Here is a screencast of what I am seeing on a test store: http://i.rocktc.de/tYAJET/31XiRHn2

chryton avatar Jun 09 '17 03:06 chryton

That's most curious. I don't get the same result at all. Let's take a quick peek at your network logs and see what actions are actually firing. In your video there should be a metafield delete call being made. If not, or if it returns some error - that will help give me some starting clues to replicate.

freakdesign avatar Jun 09 '17 11:06 freakdesign