pyxero icon indicating copy to clipboard operation
pyxero copied to clipboard

Published 20 hours ago • verified publisher icon freakboy3742

PKCE Authentication

Open rgammans opened this issue 3 years ago • 5 comments

I've written a PoC PKCE implementation. This works with my small use case, but is there any demand to get this tidied up and integrated into the rest of the library?

PoC Here: https://gist.github.com/rgammans/af01ec49c850334a91eae51c44d30583

rgammans avatar Sep 13 '21 12:09 rgammans

If there's an authentication mode that Xero supports, we'd definitely like to support it.

freakboy3742 avatar Oct 12 '21 02:10 freakboy3742

Thank you! This works great!

jeremyherbert avatar Nov 23 '21 03:11 jeremyherbert

What do you need to be included in a PR for this? Currently, I've not got any tests, and there is no final 'success' page presented to the browser.

rgammans avatar Dec 18 '21 17:12 rgammans

@rgammans Tests are definitely a requirement; documentation would also be an important piece - especially if the implementation is missing an important "final step" that the user will need to implement.

freakboy3742 avatar Dec 20 '21 23:12 freakboy3742

I'll add this to my TODO list, but I've got some unrelated work that is going to have to take priority.

rgammans avatar Dec 21 '21 19:12 rgammans