fractal
fractal copied to clipboard
Bug in nav-collapse margin-inline sizing
Steps to reproduce the issue
- Open https://demo.fractal.build demo site on desktop and start making the window smaller
- Once it hits breakpoint
@include mq($until: nav-collapse)
the menu disappears - However the main content is covered or cut off
https://github.com/frctl/fractal/assets/1784648/91c99414-2f42-4079-8e2c-eb0ccd0a0916
Reproduces how often:
100%
Reduced test case
can be reproduced live, in official demo, and many showcase implementations (ghent, mozilla etc.)
Context
- https://github.com/mozilla/protocol/issues/902
I believe there's some flawed logic in
https://github.com/frctl/fractal/blob/dd6cd938653b24cd23456d10b9c28d3bc436c4c3/packages/mandelbrot/assets/scss/core/_mixins.scss#L136
where some of the amounts should be negative, or maybe the whole argument here:
https://github.com/frctl/fractal/blob/dd6cd938653b24cd23456d10b9c28d3bc436c4c3/packages/mandelbrot/assets/scss/components/_frame.scss#L29
might be * -1
negative to fix this.