ionic-rating icon indicating copy to clipboard operation
ionic-rating copied to clipboard

lib is not minifcation safe

Open bensinther opened this issue 8 years ago • 1 comments

I have a useref task, which is outputting one single lib.js file (including ionic-rating). Afterwards I am gulp-uglify'ing that lib.js file. Unfortunately my dist app doesn't work anymore because ionic-rating is not minification safe.

As is: .controller('RatingController', function($scope, $attrs, ratingConfig) {... and .directive('rating', function($timeout) {...

To be: .controller('RatingController', ['$scope', '$attrs', 'ratingConfig', function($scope, $attrs, ratingConfig) {... and .directive('rating', ['$timeout', function($timeout) {...

Another solution could be ngInject, instead of using the DI-array.

bensinther avatar Apr 19 '16 14:04 bensinther

Yup, got this error too. I had to add the library to my js files and used ng-annotate

ladmerc avatar Sep 05 '16 09:09 ladmerc