press icon indicating copy to clipboard operation
press copied to clipboard

fix(RemoteFile): Use self.bucket instead of remote_uploads_bucket

Open cogk opened this issue 1 year ago • 2 comments

self.bucket is already used everywhere but not here

  • https://github.com/frappe/press/blob/2f435f835d81e6df33610fbd4090e6bcf4289c89/press/press/doctype/remote_file/remote_file.py#L220
  • https://github.com/frappe/press/blob/2f435f835d81e6df33610fbd4090e6bcf4289c89/press/press/doctype/remote_file/remote_file.py#L240
  • https://github.com/frappe/press/blob/2f435f835d81e6df33610fbd4090e6bcf4289c89/press/press/doctype/remote_file/remote_file.py#L248

cogk avatar Nov 05 '24 13:11 cogk

Codecov Report

:white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 29.94%. Comparing base (2f435f8) to head (5daeca2). :warning: Report is 4646 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #2258   +/-   ##
========================================
  Coverage    29.94%   29.94%           
========================================
  Files          371      371           
  Lines        28078    28078           
========================================
  Hits          8408     8408           
  Misses       19670    19670           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Nov 05 '24 13:11 codecov[bot]

Hello! Is there any update on this? Can you fix the issues?

ssiyad avatar Nov 12 '25 08:11 ssiyad

Hey, no sorry :joy: I can't “fix the issues” more than I already have there, the linter issues are not strictly related to my changes if I'm not mistaken! And I won't fix code which is not related to the actual fix.

I think this infrastructure team will need to review this to ensure there is no issue with what is actually deployed on the Frappe Cloud infra.

(I deployed this in production on a fork for several months without issue)

cogk avatar Nov 22 '25 03:11 cogk