press icon indicating copy to clipboard operation
press copied to clipboard

feat(PrometheusAlertReaction): Add doctype for recording reaction for alert

Open balamurali27 opened this issue 11 months ago • 2 comments

  • Add tab in Alert Rule for defining rule

balamurali27 avatar Mar 14 '24 12:03 balamurali27

Codecov Report

Attention: Patch coverage is 82.35294% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 43.08%. Comparing base (cb9726e) to head (5cc201f). Report is 146 commits behind head on master.

:exclamation: Current head 5cc201f differs from pull request most recent head fd07e85. Consider uploading reports for the commit fd07e85 to get more accurate results

Files Patch % Lines
...etheus_alert_reaction/prometheus_alert_reaction.py 73.33% 4 Missing :warning:
...ertmanager_webhook_log/alertmanager_webhook_log.py 89.47% 2 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1566      +/-   ##
==========================================
+ Coverage   39.79%   43.08%   +3.28%     
==========================================
  Files         317      317              
  Lines       25537    22062    -3475     
==========================================
- Hits        10163     9505     -658     
+ Misses      15374    12557    -2817     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Mar 14 '24 13:03 codecov[bot]

@balamurali27 don't see any safeguard for how many times this should be allowed to run.

IMO it should not be more than 1.5-2x the actual size on dedicated servers. On our servers we can keep the threshold slightly higher before manual intervention is required.

ankush avatar Apr 10 '24 11:04 ankush