Expense claim payment don't consider taxes and charges while making payment.

[sjain17]

Description of the issue

While making payment using Journal Entry against an expense claim, system is not considering the taxes and charges into Total Sanction Amount and it leaves the expense unpaid.

Context information (for bug reports)

Output of bench version

erpnext 13.0.0-beta.9
frappe 13.0.0-beta.9

Steps to reproduce the issue

1. Create an expense claim with any expense type and add taxes and charges in the Expense Taxes and Charges >> Approve it >> Submit it.
2. Change Accounts Setting >> Make Payment via Journal Entry =1 (True)
3. Create Payment

Observed result

Case -1. Payment through Journal Entry (Bank Entry)

1. Total Sanctioned Amount is sum of total expenses.
2. Grand Total is sum of Expenses Sanctioned amount + Expense Taxes and Charges
3. Payment is made for Sanctioned Amount Only if made through Journal Entry (Type Bank Entry). In this case expense status is unpaid even after payment.

Case -2. Payment through Payment Entry

1. Total Sanctioned Amount is sum of total expenses.
2. Grand Total is sum of Expenses Sanctioned amount + Expense Taxes and Charges
3. Payment is made for Grand Total Amount if made through Payment Entry. In this case expense status is paid after payment is submitted.

Expected result

1. Total Sanctioned Amount is sum of total expenses.
2. Grand Total is sum of Expenses Sanctioned amount + Expense Taxes and Charges
3. Payment should be always made for Grand total in any case i.e., payment via payment process or journal entry.

Stacktrace / full error message

(paste here)

Additional information

OS version / distribution, ERPNext install method, etc.

[jryandechavez]

Encountered same issue, Grand Total should be the sum of Expenses Sanctioned amount + Expense Taxes and Charges

[sjain17]

Encountered same issue, Grand Total should be the sum of Expenses Sanctioned amount + Expense Taxes and Charges

Any luck on issue?

[ruchamahabal]

Fixed via https://github.com/frappe/erpnext/pull/31724 https://github.com/frappe/erpnext/pull/31614