gantt icon indicating copy to clipboard operation
gantt copied to clipboard

Published 20 hours ago • verified publisher icon frappe

Option to enable grouping and add multiple tasks to a row - rebase

Open stephenjmaher opened this issue 8 months ago • 6 comments

I came across #448 and thought the feature would be of value. I have rebased the changes from @iaminamcom to bring it up to date with the current master.

stephenjmaher avatar Apr 02 '25 14:04 stephenjmaher

Thanks! Can you please add screenshots?

safwansamsudeen avatar Apr 14 '25 04:04 safwansamsudeen

Do you want screenshots to included in this PR? Or are they for the README?

stephenjmaher avatar Apr 14 '25 04:04 stephenjmaher

Here are what the changes will look like.

image

image

stephenjmaher avatar Apr 14 '25 04:04 stephenjmaher

When will this be merged into the main branch?

stonesoft-tech avatar May 17 '25 14:05 stonesoft-tech

I would like to merge these changes. I am just waiting on approval from someone with write access.

stephenjmaher avatar May 19 '25 04:05 stephenjmaher

Can this be approved so it can be merged? Please!!!

stonesoft-tech avatar May 20 '25 07:05 stonesoft-tech

There is an issue with this in Safari...

Gantt won't load when grouping:true

The following error is caught from line 24 of frappe-gantt.umd.js: s.union is not a function. (In 's.union(new Set(this.tasks.map(a=>a.group)))', 's.union' is undef

Works fine in Chrome and Firefox

stonesoft-tech avatar Jul 05 '25 08:07 stonesoft-tech

@stonesoft-tech The use of union has been removed. Could you please check this on Safari now?

stephenjmaher avatar Jul 07 '25 10:07 stephenjmaher

@stonesoft-tech The use of union has been removed. Could you please check this on Safari now?

Sure thing. Will test later tonight. Thanks!

stonesoft-tech avatar Jul 07 '25 12:07 stonesoft-tech

@stonesoft-tech The use of union has been removed. Could you please check this on Safari now?

This is working on Safari. Thanks.

It looks like the Scroll to Today is not functioning though in Safari. It scrolls to the beginning of the chart... No errors in the console.

stonesoft-tech avatar Jul 07 '25 14:07 stonesoft-tech

Do you know if the error with "Scoll to Today" is due to the changes in the MR? I don't know what changes could have been introduced to cause this to stop working.

stephenjmaher avatar Jul 08 '25 04:07 stephenjmaher

Do you know if the error with "Scoll to Today" is due to the changes in the MR? I don't know what changes could have been introduced to cause this to stop working.

No because it wouldn't load at all before the MR. I will test on the original build (without grouping) and create a new issue.

stonesoft-tech avatar Jul 08 '25 13:07 stonesoft-tech

Hey team, will this PR be merged? 😄

calebeaires avatar Aug 07 '25 12:08 calebeaires

Hey @calebeaires - I'm not actively working on Gantt right now - when I get back to it (probably next month), I'll review and merge.

safwansamsudeen avatar Aug 14 '25 09:08 safwansamsudeen

@stephenjmaher this PR seems to be broken in a couple places (for example, you can't drag or edit anything but the first bar in a group) :(.

safwansamsudeen avatar Oct 10 '25 05:10 safwansamsudeen

Sorry @safwansamsudeen, It was an error in the example html. The tasks in the same group had the same ID. The example has been updated now.

Were there any other errors that you found?

stephenjmaher avatar Oct 12 '25 11:10 stephenjmaher