gantt icon indicating copy to clipboard operation
gantt copied to clipboard

Few functions and fixes to the gantt

Open WurstMitBrot opened this issue 5 years ago • 12 comments

Hello,

i added a few functions i needed for a project.

  • I made dependencies editable. You now can create new dependencies using the pop up and delete them by clicking on the arrows. These actions also fire events
  • Editing the tasks and dependencies is optional
  • The months in the pop up are now localized
  • The pop up don't overlay the bars anymore
  • Added german localization
  • changed mouse events while draging bars from offsetX to clientX

WurstMitBrot avatar Apr 17 '19 10:04 WurstMitBrot

Think this line in frappe-gantt.js should be outside the else condition. It's currently breaking custom_popup_html because they don't get shown.

        	// SJ fix popup overlaying bars
        	this.parent.style.display = 'block';
        }

core44 avatar Apr 22 '19 10:04 core44

Please resolve the conflicts and make the changes requested by @core44

Anurag810 avatar Apr 29 '19 05:04 Anurag810

This PR fixed an issue where if I dragged a task to the right (future) it would actually save it's date a few months in the past.

I assume this has to do with changed mouse events while draging bars from offsetX to clientX which @WurstMitBrot mentioned.

(I have currently hacked this in my ERPNext server)

TimVosch avatar Jun 09 '19 18:06 TimVosch

+1 Please merge as soon as possible.

parsimonyERP avatar Apr 19 '20 19:04 parsimonyERP

Hi @netchampfaris,

I'm sorry i just saw your suggestions today. Thank you for your feedback. I changed everything as desired.

WurstMitBrot avatar May 28 '20 14:05 WurstMitBrot

merged already?

ofebles avatar Mar 03 '21 13:03 ofebles

@ofebles still waiting for a reaction. Fixed all the suggestions and never heared something.

WurstMitBrot avatar Mar 03 '21 13:03 WurstMitBrot

@ofebles still waiting for a reaction. Fixed all the suggestions and never heared something.

Hi @WurstMitBrot , if i get your branch and overwrite in node modules my frappe-gantt folder , should this works? Its urgent for me. Any help? I got this issue related with all tasks are showing in the same init/end dates range. Im using it in erpnext v12.

ofebles avatar Mar 03 '21 19:03 ofebles

Why has this issue been unresolved for two years? I've sold my team on moving our operation to erpNext and the very first item, the Gantt Chart, the office manager tries to use is broken, and has been broken for two years.

#frappe/erpnext#19348

wpleasant avatar May 20 '21 15:05 wpleasant

@netchampfaris and @Anurag810 do i have to fix something?

WurstMitBrot avatar May 20 '21 16:05 WurstMitBrot

@netchampfaris and @Anurag810

Is there a reason why no one is reviewing it, or clarifying what changes are needed for this to get added?

sahil48 avatar Sep 22 '21 01:09 sahil48

@netchampfaris and @Anurag810 fixed merge conflicts. Is there any chance this will be added?

WurstMitBrot avatar May 19 '22 20:05 WurstMitBrot