gameplan icon indicating copy to clipboard operation
gameplan copied to clipboard

Uploaded videos in post does not play

Open kramteo opened this issue 1 year ago • 1 comments

I have uploaded a video in posts (MP4 file). However, there is no way to play the video when viewing the post.

I have tried to double-click on the video and also move cursor around, but cannot activate the video.

I suppose since videos can be uploaded, there must be able to be played.

I am on Gameplan: v0.0.1 (HEAD) / Frappe Framework: v15.39.0 (HEAD)

Appreciate any advice on my issue. Thanks!

Screenshot 2024-08-27 144441

kramteo avatar Aug 27 '24 07:08 kramteo

Valid issue, currently you can't play any videos in pages. Videos are only playable when the document is not editable inside an editor. That only happens when a user makes a post in Gameplan, so the video becomes playable.

Can't do the same with pages currently, since a page is never "published" it's always editable. Will update to fix this.

Cause: https://github.com/frappe/frappe-ui/blob/4f168d8a7ce0a93b1560c902d8907a7ff4ea4af4/src/components/TextEditor/video-extension.js#L39-L41

uhrjun avatar Aug 31 '24 09:08 uhrjun