gameplan fix/task details

fix: task detail
fix: pop up actions

closes: #298 closes: #295 closes: #292

Jul 23 '24 00:07 blaggacao

I have just three things to teach: simplicity, patience, compassion. These three are your greatest treasures. - Lao Tzu

_{Kindly help move this PR forward. Many thanks from Yours Sincerely!}

Jul 29 '24 06:07 blaggacao

@netchampfaris Could you please take a closer look at this? Thx!

Jul 29 '24 13:07 blaggacao

The important thing is this: to be able at any moment to sacrifice what we are for what we could become. - Charles Dubois

_{Kindly help move this PR forward. Many thanks from Yours Sincerely!}

Aug 02 '24 07:08 blaggacao

Obstacles are those frightful things you see when you take your eyes off your goal. - Henry Ford

_{Kindly help move this PR forward. Many thanks from Yours Sincerely!}

Aug 05 '24 16:08 blaggacao

Our distrust is very expensive. - Ralph Emerson

_{Kindly help move this PR forward. Many thanks from Yours Sincerely!}

Aug 09 '24 10:08 blaggacao

An invincible determination can accomplish almost anything and in this lies the great distinction between great men and little men. - Thomas Fuller

_{Kindly help move this PR forward. Many thanks from Yours Sincerely!}

Aug 25 '24 06:08 blaggacao

rebase?

Aug 26 '24 10:08 rmehta

gameplan Run #273

Run Properties: Failed #273 • f28a7d17ed ℹ️: Merge 49073fd0de7e198caee42efec50a077b266bb5d6 into 309e1c887128ace7a26d8565c266...

Project	`gameplan`
Run status	`Failed #273`
Run duration	`02m 48s`
Commit	`f28a7d17ed ℹ️: Merge 49073fd0de7e198caee42efec50a077b266bb5d6 into 309e1c887128ace7a26d8565c266...`
Committer	`David Arnold`
View all properties for this run ↗︎

Test results
Failures	`5`
Flaky	`0`
Pending	`0`
Skipped	`0`
Passing	`1`

Tests for review

discussion.cy.js • 1 failed test

View Output Video

Test		Artifacts
Discussion > all discussion actions		`Screenshots` `Video`

onboarding.cy.js • 1 failed test

View Output Video

Test		Artifacts
Onboarding > onboarding works		`Screenshots` `Video`

project.cy.js • 1 failed test

View Output Video

Test		Artifacts
Project > project creation, move to team and archive		`Screenshots` `Video`

task.cy.js • 1 failed test

View Output Video

Test		Artifacts
Task > task actions		`Screenshots` `Video`

team.cy.js • 1 failed test

View Output Video

Test		Artifacts
Team > team creation, readme edit and archive		`Screenshots` `Video`

Aug 26 '24 11:08 cypress[bot]

ack, asap

Oct 17 '24 20:10 blaggacao

@blaggacao

Dialog action API was broken in frappe-ui, it's now fixed. close function was meant to be passed in a object. It's now fixed with https://github.com/frappe/gameplan/commit/6e5268ef619ce205e3966cc7188eea6c341524da I have also fixed the task assignment issue in https://github.com/frappe/gameplan/commit/ef6589473547dab7f522482aea3931744037a13a

Thanks for your work, this PR can be closed now.

Nov 21 '24 19:11 netchampfaris

Tanks a lot!

Nov 22 '24 14:11 blaggacao