frappe
revert: re-enable workspaces
https://github.com/frappe/gameplan/commit/f9c8db3ed8120e6e31799d01065a5c60461aedce
The original "chore" commit didn't specify a specific reason.
On the other hand, the lack of a proper workspace configuration breaks the Frappix build of Gameplan.
This PR re-instates the workspaces and heals Frappix builds of Gameplan
5 failed tests on run #248 ↗︎
 5 |
 1 |
 0 |
 0 |
 0 |
Details:
| Merge 41b59368692364b234fc41ed13369e81e9a7428e into d357258784047244878ed479c7f6... | |||
| Project: gameplan | Commit: 2b8d445c85 ℹ️ |
||
| Status: Failed | Duration: 02:40 💡 | ||
| Started: Jul 23, 2024 1:43 AM | Ended: Jul 23, 2024 1:46 AM | ||
discussion.cy.js • 1 failed test
| Test | Artifacts | |
|---|---|---|
| Discussion > all discussion actions |
Screenshots
Video
|
|
onboarding.cy.js • 1 failed test
| Test | Artifacts | |
|---|---|---|
| Onboarding > onboarding works |
Screenshots
Video
|
|
project.cy.js • 1 failed test
| Test | Artifacts | |
|---|---|---|
| Project > project creation, move to team and archive |
Screenshots
Video
|
|
team.cy.js • 1 failed test
| Test | Artifacts | |
|---|---|---|
| Team > team creation, readme edit and archive |
Screenshots
Video
|
|
Review all test suite changes for PR #278 ↗︎
![cypress[bot] avatar](https://avatars.githubusercontent.com/in/9078?v=4 "Published by a pub.dev verified publisher"){kind=small}
@netchampfaris I removed the motion stuff. I guess this could now be re-considered? It would really help me to package Gameplan in Frappix.
@netchampfaris Could this be reconsidered? It's kind of a particular interest requirement, but given that the other new style apps use workspaces (afaik: Crm, Builder & Insights) there might be an independent value on aligning the code layout between projects.
As a collateral it would really help me package GamePlan properly for Frappix. :smile:
Go for it now. The future is promised to no one. - Wayne Dyer
Kindly help move this PR forward. Many thanks from Yours Sincerely!
Fears are nothing more than a state of mind. - Napoleon Hill
Kindly help move this PR forward. Many thanks from Yours Sincerely!
What the caterpillar calls the end of the world, the master calls a butterfly. - Richard Bach
Kindly help move this PR forward. Many thanks from Yours Sincerely!
Watch your thoughts, they become your words Watch your words, they become your actions Watch your actions, they become your habits Watch your habits, they become your character Watch your character, it becomes your destiny. -
Kindly help move this PR forward. Many thanks from Yours Sincerely!
You may say Im a dreamer, but Im not the only one, I hope someday you will join us, and the world will live as one. - John Lennon
Kindly help move this PR forward. Many thanks from Yours Sincerely!
I have just three things to teach: simplicity, patience, compassion. These three are your greatest treasures. - Lao Tzu
Kindly help move this PR forward. Many thanks from Yours Sincerely!
@netchampfaris Could you please verify if 41b59368692364b234fc41ed13369e81e9a7428e is also an independent fix? Thank you!
The important thing is this: to be able at any moment to sacrifice what we are for what we could become. - Charles Dubois
Kindly help move this PR forward. Many thanks from Yours Sincerely!
Obstacles are those frightful things you see when you take your eyes off your goal. - Henry Ford
Kindly help move this PR forward. Many thanks from Yours Sincerely!
Our distrust is very expensive. - Ralph Emerson
Kindly help move this PR forward. Many thanks from Yours Sincerely!
An invincible determination can accomplish almost anything and in this lies the great distinction between great men and little men. - Thomas Fuller
Kindly help move this PR forward. Many thanks from Yours Sincerely!