frappe_docker icon indicating copy to clipboard operation
frappe_docker copied to clipboard

Documentation variables outdated

Open r1ckr opened this issue 10 months ago • 4 comments

Description of the issue

In the documentation mentions the variable FRAPPE_VERSION, but in the example.env file it doesn't exists, instead it is ERPNEXT_VERSION.

I think the change is pretty simple, just change the variable in the example file to FRAPPE_VERSION.

r1ckr avatar Apr 11 '24 09:04 r1ckr

Please send PR.

revant avatar Apr 11 '24 11:04 revant

Sent

r1ckr avatar Apr 11 '24 12:04 r1ckr

My understanding is that ERPNEXT_VERSION is version of the ERPNext Docker image that is pulled when you are not building your own, whereas FRAPPE_BRANCH and FRAPPE_PATH are used for the Frappe framework repo and version. Is this correct?

gparent avatar Apr 11 '24 22:04 gparent

Then the documentation is the one that needs to be updated?

r1ckr avatar Apr 12 '24 11:04 r1ckr

This issue has been automatically marked as stale. You have a week to explain why you believe this is an error.

github-actions[bot] avatar Jun 12 '24 00:06 github-actions[bot]