frappe icon indicating copy to clipboard operation
frappe copied to clipboard

fix: refactor document.get definition (#26280)

Open casesolved-co-uk opened this issue 9 months ago • 1 comments

fix: change document.get definition to match dict.get and add positional deprecation warning to the filters keyword

fixes: https://github.com/frappe/frappe/issues/26280

Have attempted to fix all core files using the new filters= arg

See also https://github.com/frappe/frappe/issues/26279

version-14-hotfix version-15-hotfix

casesolved-co-uk avatar May 01 '24 18:05 casesolved-co-uk

@casesolved-co-uk can you please raise PRs from personal account instead of org forks

https://github.com/frappe/erpnext/wiki/Pull-Request-Checklist#maintainer-edits

ankush avatar May 03 '24 12:05 ankush

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed within 3 days if no further activity occurs, but it only takes a comment to keep a contribution alive :) Also, even if it is closed, you can always reopen the PR when you're ready. Thank you for contributing.

stale[bot] avatar May 22 '24 07:05 stale[bot]

@casesolved-co-uk can you please raise PRs from personal account instead of org forks

https://github.com/frappe/erpnext/wiki/Pull-Request-Checklist#maintainer-edits

No

This PR is available here: https://github.com/CaseSolvedUK/frappe

casesolved-co-uk avatar May 22 '24 14:05 casesolved-co-uk