frappe
frappe copied to clipboard
Copy paste from Excel to grid do not consider field datatype before setting values
Description of the issue
Copy paste from Excel to grid do not consider field datatype before setting values, so values are not presented correctly
Context information (for bug reports)
When you copy from a Excel sheet and paste values into a grid, currently the code makes a simple set_value to the field, but if values are formatted, for instance, currency with comma as decimal separator or dates in dd/mm/yyyy format, those values are not correctly take into each field of the grid.
Output of bench version
v14.40.2
Steps to reproduce the issue
- Open any grid with fields of datatype date and currency
- Copy values from Excel sheet, using dates formatted as dd/mm/yyyy and values with comma as decimal separator
- Paste into the grid
Observed result
Values aren't set in the grid as shown in the attached image
Expected result
Values should be set in the grid fields the same way the data came from Excel
Stacktrace / full error message
N/A
Additional information
OS version / distribution, Frappe
install method, etc.
@phot0n could you please check my PR ?
:tada: This issue has been resolved in version 14.71.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:
:tada: This issue has been resolved in version 15.21.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket: