frappe icon indicating copy to clipboard operation
frappe copied to clipboard

Breadcrumb when viewing a dashboard should be linked to Module/Workspace rather than Dashboard list

Open nikkothari22 opened this issue 2 years ago • 1 comments

Description of the issue

When we create a Dashboard for a particular module, the breadcrumbs on the Dashboard are as follows:

Home > Dashboard > Dashboard Name

image

This is very confusing for the users because they cannot go back to the workspace where they entered the dashboard from. The "Dashboard" link takes them to the Dashboard list.

Screen Recording 2022-08-31 at 10 49 44 AM

Steps to reproduce the issue

  1. Open any dashboard
  2. The breadcrumb will take you back to dashboard list rather than the Workspace the dashboard belongs to.

nikkothari22 avatar Aug 31 '22 05:08 nikkothari22

Upon checking the codebase, I think we could have a field in the Dashboard form where they can choose the Workspace/Page this dashboard belongs to. Then on page render, we fetch the Workspace name and add the breadcrumb. If no workspace is selected, we can default to the Dashboard list.

nikkothari22 avatar Aug 31 '22 05:08 nikkothari22

IMO breadcrumb logic should be changed to:

  1. Guess hierarchy from which a page is possible to reach. e.g. workspace1 -> dashboard and workspace2 -> same dashboard
  2. If directly reached just assign some breadcrumb based on heuristics
  3. If browsed from desk then use actual route history to create breadcrumb.

If I visit same dashboard from two workspace the breadcrumb should show workspace I visited it from and not random name.

ankush avatar Mar 31 '23 04:03 ankush

@ruchamahabal :eyes:

ankush avatar Jun 03 '24 07:06 ankush

Breadcrumbs are not tied to workspaces now so shouldn't be a problem in the new desk

Partially solved here: https://github.com/frappe/frappe/pull/26638 (will add screenshots/desc soon) ref doc's Module will be shown in the breadcrumb and that module's sidebar will get rendered in the ModuleShell.

ruchamahabal avatar Jun 03 '24 07:06 ruchamahabal