frappe-ui icon indicating copy to clipboard operation
frappe-ui copied to clipboard

Published 20 hours ago • verified publisher icon frappe

Buttons should probably have type="button" by default

Open cogk opened this issue 6 months ago • 0 comments

Because without this attribute, buttons have type=submit which is awful in both UX for the blind, could lead to unintentional form submission, and is bad DX for devs (you have to prevent submission when using <form>).

https://github.com/frappe/frappe-ui/blob/a5d24ee27bb0ff6c72928fbbda44ce6d3de8569e/src/components/Button.vue#L2-L7

cogk avatar Aug 16 '24 17:08 cogk