erpnext icon indicating copy to clipboard operation
erpnext copied to clipboard

Supporting another calendar

Open AbdullahObaid opened this issue 8 years ago • 24 comments

Hi, I know the issue already asked many times ( #3473 #8851 ), I'm trying here to clarify what is the issue exactly and how it should be resolved.

Many countries use different calendar systems than Georgian, for us we use Hijri Calendar. As a non python developer I don't know how to implement my solution that I already implemented in many other projects I worked in.

To clarify, supporting Hijri Calendar Doesn't require changing anything in the database or the backend , how we implement it is :

  1. Everything in the database is stored in Georgian Dates as usual.
  2. We need to change the date picker to another one that supports Hijri Dates for example
  3. We need to add a processor that convert any date we get from the Database - before sending it to the view - to it's equivalent Hijri date - here is a Hijri Date Converter for python.

To sum up : The date conversion happens after we get the input from the user ( Hijri to Georgian ) and before we display any date to the user ( Georgian to Hijri )

If I know python I would be happy to implement this feature myself, and it will not a lot of time to do. I wrote the idea here that we use in our PHP, ASP web apps so if someone can implement. I can help to explain any details if someone is interested.

Thanks

AbdullahObaid avatar May 16 '17 15:05 AbdullahObaid

+1

mhbu50 avatar May 16 '17 16:05 mhbu50

+1

j209 avatar May 18 '17 22:05 j209

+1

me2ne avatar Feb 13 '18 08:02 me2ne

+1

smayar avatar Jun 04 '18 07:06 smayar

some country like Iran also use Hijri Shamsi calendar that is different with Hijri calendar use in Saudi Arabia

me2ne avatar Jun 11 '18 10:06 me2ne

+1

ahmed-madi avatar Aug 17 '18 12:08 ahmed-madi

If some one can add this option it will be great and we can make many implementation in GCC. I can contribute as well by supporting developer with some funds

gsbaig avatar Mar 10 '19 09:03 gsbaig

I have done this feature for Odoo and I would like to do this for ERPNext. @AbdullahObaid please share your knowledge with me. Thanks.

mostify avatar Jun 26 '20 08:06 mostify

Dear Mostafa, did you finish this hijri calendar with erpnext

On Fri, Jun 26, 2020 at 11:19 AM Mostafa [email protected] wrote:

I have done this feature for Odoo and I would like to do this for ERPNext. @AbdullahObaid https://github.com/AbdullahObaid please share your knowledge with me. Thanks.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/frappe/erpnext/issues/8874#issuecomment-650050871, or unsubscribe https://github.com/notifications/unsubscribe-auth/AALXCXZXP2SAIQ73DY6PS43RYRK2HANCNFSM4DLSX3OA .

gsbaig avatar Jul 26 '20 08:07 gsbaig

Dear Mostafa, did you finish this hijri calendar with erpnext On Fri, Jun 26, 2020 at 11:19 AM Mostafa @.***> wrote: I have done this feature for Odoo and I would like to do this for ERPNext. @AbdullahObaid https://github.com/AbdullahObaid please share your knowledge with me. Thanks. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#8874 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AALXCXZXP2SAIQ73DY6PS43RYRK2HANCNFSM4DLSX3OA .

No, I am going to start. Have you any idea?

mostify avatar Aug 03 '20 10:08 mostify

@SafaCore any update ?

ShahzadNaser avatar Sep 19 '20 11:09 ShahzadNaser

+1

zeintiz avatar Jun 13 '21 13:06 zeintiz

+1

abehnamfard avatar Aug 24 '21 05:08 abehnamfard

Is this related to https://github.com/t1m0n/air-datepicker/issues/193 ?

SudoNova avatar Oct 07 '21 11:10 SudoNova

is there any update regarding this ?

hadeeld7 avatar Jan 13 '22 10:01 hadeeld7

@AbdullahObaid A few other things need to change

  1. Some queries that refer to this month (or this week) (for example: Profit rate from the beginning of the month until now)
  2. Some JavaScript components that are related to date (date picker , calendar , timeline...)

moosavimaleki avatar Apr 14 '22 14:04 moosavimaleki

+1

mohamadosama avatar Jul 31 '22 15:07 mohamadosama

it's called "Jalali" calendar not "Hijri Shamsi" and there are many opensource packages for it.

hadifarnoud avatar Nov 15 '22 09:11 hadifarnoud

@ankush Could you add this as an option to the current Date control:

https://github.com/ronozoro/frappe_hijri_datepicker

mhbu50 avatar Nov 16 '22 09:11 mhbu50

@mhbu50 feel free to send PR. Someone from our team can work on it to get it merged in core.

I personally do not have much context on this issue :sweat_smile:

ankush avatar Nov 16 '22 14:11 ankush

Hello every one. is this issue still a thing? just western calendars are accepted in ERP next?

Shahin-rmz avatar Feb 21 '23 20:02 Shahin-rmz

Check out this short demo I made to show how Nepali Date Integration in Frappe Framework v15 works:

Watch it here: https://www.youtube.com/watch?v=26iOn4RIjLE

lekhnath avatar Apr 11 '24 10:04 lekhnath