frappe
fix: header_img field schema (backport payments #83)
This is a manual backport of https://github.com/frappe/payments/pull/83. The gocardless_settings.json is still in the ERPNext app in version 14, not yet moved over to payments. This schema update is necessary for GoCardless to function. Closes #34731.
This pull request has been automatically marked as inactive because it has not had recent activity. It will be closed within 3 days if no further activity occurs, but it only takes a comment to keep a contribution alive :) Also, even if it is closed, you can always reopen the PR when you're ready. Thank you for contributing.
![stale[bot] avatar](https://avatars.githubusercontent.com/in/1724?v=4 "Published by a pub.dev verified publisher"){kind=small}
@NagariaHussain You merged this change into frappe/payments to fix GoCardless in develop and version-15 branches. Can you please help get it merged into frappe/erpnext version-14? The json file is still part of the erpnext app in version-14 and not moved over to the payments app yet. Without this backport, gocardless is broken in version-14. Thank you!
This pull request has been automatically marked as inactive because it has not had recent activity. It will be closed within 3 days if no further activity occurs, but it only takes a comment to keep a contribution alive :) Also, even if it is closed, you can always reopen the PR when you're ready. Thank you for contributing.
Can anyone please help this get merged for GoCardless? @NagariaHussain ?
This pull request has been automatically marked as inactive because it has not had recent activity. It will be closed within 3 days if no further activity occurs, but it only takes a comment to keep a contribution alive :) Also, even if it is closed, you can always reopen the PR when you're ready. Thank you for contributing.
Can anyone on the frappe team take a look so GoCardless can work on version-14 again? @s-aga-r you did the last merge on this repository for GoCardless. Can you please review and/or merge? Or assign to whoever would be responsible? Thanks in advance!
This pull request has been automatically marked as inactive because it has not had recent activity. It will be closed within 3 days if no further activity occurs, but it only takes a comment to keep a contribution alive :) Also, even if it is closed, you can always reopen the PR when you're ready. Thank you for contributing.
All that extra JSON is very old, going back to version-11 at least. Lots of field attributes with "0" as the data. I'm guessing that when I add the field, frappe is deciding they are defaults that don't need to be specified. But I'm not sure, TBH. All I did was add the field, and this is how the JSON came out. No manual tweaking.
Cool. The linter check is failing, can you check?
Once that is fixed, I will merge.
@NagariaHussain I have attempted to run pre-commit checks as per the erpnext Pull-Request-Checklist, but it is my first time doing so, so I'm sorry if I'm not doing it correctly, but it looks ok to me. I chnaged the timestamp on the json file to trigger checking the file and the json check passed:
This pull request has been automatically marked as inactive because it has not had recent activity. It will be closed within 3 days if no further activity occurs, but it only takes a comment to keep a contribution alive :) Also, even if it is closed, you can always reopen the PR when you're ready. Thank you for contributing.
Ah, ah, ah, ah Stayin' alive, stayin' alive Ah, ah, ah, ah Stayin' alive
This pull request has been automatically marked as inactive because it has not had recent activity. It will be closed within 3 days if no further activity occurs, but it only takes a comment to keep a contribution alive :) Also, even if it is closed, you can always reopen the PR when you're ready. Thank you for contributing.
@NagariaHussain I checked what I'm able to check with pre-commit- no failures there. I can't figure out why linters would fail with exit code 7 in Annotations. And I don't know if it is relevant to this simple json file change. Please advise.
This pull request has been automatically marked as inactive because it has not had recent activity. It will be closed within 3 days if no further activity occurs, but it only takes a comment to keep a contribution alive :) Also, even if it is closed, you can always reopen the PR when you're ready. Thank you for contributing.
@NagariaHussain Is there any way you can still merge this? Anybody?
:tada: This PR is included in version 14.78.9 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:
