Pricing Rule is broken on most of `Apply Rule On Other` options

[ruthra-kumar]

Pricing Rules where the discount / margin is applied on other item code / item group / brand is broken.

Broken Scenarios:

-	Apply On	Value	Apply Rule on Other	Value
1	Item Code	Item 1	Item Code	Item 2
2	Item Group	All Item Group	Item Group	All Item Group
3	Item Code/Group	any_value	Brand	any_value

On above cases, the discount is applied on the trigger item itself, either on item addition or upon save.

Version

v14 and v15

References: https://support.frappe.io/helpdesk/tickets/16804 https://support.frappe.io/helpdesk/tickets/17723 https://support.frappe.io/helpdesk/tickets/15810